[asterisk-dev] [Code Review] MixMonitor external test

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/632/#review1917
-----------------------------------------------------------



/asterisk/trunk/tests/mixmonitor/run-test
<https://reviewboard.asterisk.org/r/632/#comment4137>

    remove "base=" on these lines



/asterisk/trunk/tests/mixmonitor/run-test
<https://reviewboard.asterisk.org/r/632/#comment4138>

    I assume the only exception you're trying to catch is if the file doesn't exist.  Why not just explicitly check os.path.exists() first instead of try/except?



/asterisk/trunk/tests/mixmonitor/run-test
<https://reviewboard.asterisk.org/r/632/#comment4136>

    Parenthesis are not needed here (or a few other similar places)


- Russell


On 2010-04-28 14:30:16, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/632/
> -----------------------------------------------------------
> 
> (Updated 2010-04-28 14:30:16)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> MixMonitor external test.
> 
> Tests MixMonitor with StopMixMonitor, verifying that StopMixMonitor releases the audio file so it can be processed by the dialplan.
> Tests MixMonitor without StopMixMonitor, verifying that MixMonitor stops correctly on hangup.
> Tests the size of the two audio files to see if they are what we expect given the length of time processed.
> 
> Future improvements to this test will include using AUDIOHOOK_INHERIT.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/mixmonitor/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/mixmonitor/run-test PRE-CREATION 
>   /asterisk/trunk/tests/mixmonitor/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/632/diff
> 
> 
> Testing
> -------
> 
> Test passes with trunk and 1.4
> 
> 
> Thanks,
> 
> David
> 
>