[asterisk-dev] [Code Review] MixMonitor external test

[David Vossel]

> On 2010-04-28 14:24:29, David Vossel wrote:
> > /asterisk/trunk/tests/mixmonitor/run-test, lines 80-89
> > <https://reviewboard.asterisk.org/r/632/diff/1/?file=9693#file9693line80>
> >
> >     For setting the TESTAUDIO variables, "core set global" works for all versions right now, so use that.

Great Idea! Thanks for the review :)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/632/#review1913
-----------------------------------------------------------


On 2010-04-28 13:58:34, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/632/
> -----------------------------------------------------------
> 
> (Updated 2010-04-28 13:58:34)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> MixMonitor external test.
> 
> Tests MixMonitor with StopMixMonitor, verifying that StopMixMonitor releases the audio file so it can be processed by the dialplan.
> Tests MixMonitor without StopMixMonitor, verifying that MixMonitor stops correctly on hangup.
> Tests the size of the two audio files to see if they are what we expect given the length of time processed.
> 
> Future improvements to this test will include using AUDIOHOOK_INHERIT.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/mixmonitor/configs/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/mixmonitor/run-test PRE-CREATION 
>   /asterisk/trunk/tests/mixmonitor/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/632/diff
> 
> 
> Testing
> -------
> 
> Test passes with trunk and 1.4
> 
> 
> Thanks,
> 
> David
> 
>