[asterisk-dev] [Code Review] LibPRI changes for Generic AOC

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/619/
-----------------------------------------------------------

(Updated 2010-04-23 17:46:45.035932)


Review request for Asterisk Developers.


Changes
-------

This update contains a optimization in the timeout period in which the AOC request waits for a response.  Rather than waiting for a specified about of time for an AOC request response, we can timeout after we receive the CONNECT message since the response must come before then.  This is just a more accurate way of handling the request response.  This update also adds support for handling empty AOC-S currency lists.  Thanks to rmudgett for implementing these changes.


Summary
-------

This review compliments the Asterisk changes in review https://reviewboard.asterisk.org/r/552/.  These are the LibPRI changes required to send ETSI AOC messages generated by Asterisk.


Diffs (updated)
-----

  /team/rmudgett/aoc_event/libpri.h 1663 
  /team/rmudgett/aoc_event/pri_aoc.c 1663 
  /team/rmudgett/aoc_event/pri_facility.h 1663 
  /team/rmudgett/aoc_event/pri_facility.c 1663 
  /team/rmudgett/aoc_event/pri_internal.h 1663 
  /team/rmudgett/aoc_event/q931.c 1663 

Diff: https://reviewboard.asterisk.org/r/619/diff


Testing
-------

These routines have been tested back to back with Asterisk, but I am going to need some community help to test interoperability.

To test this code, check out both my Asterisk and Libpri changes for AOC

Asterisk Changes: svn/asterisk/team/dvossel/generic_aoc
LibPRI Changes: svn/libpri/team/dvossel/aoc_send 


Thanks,

David