[asterisk-dev] [Code Review] Crash in audiohook_write_list

Kaloyan Kovachev kkovachev at varna.net
Fri Apr 23 11:41:16 CDT 2010


On Fri, 23 Apr 2010 11:28:42 -0500, Kevin P. Fleming wrote
> Kaloyan Kovachev wrote:
> 
> > Yes, but in case of error we do not know what is the content of (possibly
> > partially) modified frame, so either:
> 
> A manipulate callback should not modify the frame unless it is going to
> return non-failure; a failure result should always leave the frame
> unmodified.
> 

Then i don't understand why it should be freed instead of being passed to
other manipulate callbacks?

> -- 
> Kevin P. Fleming
> Digium, Inc. | Director of Software Technologies
> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
> skype: kpfleming | jabber: kfleming at digium.com
> Check us out at www.digium.com & www.asterisk.org
> 
> -- 
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
> 
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev




More information about the asterisk-dev mailing list