[asterisk-dev] [Code Review] ETSI Explicit Call Transfer (ECT) support. (libpri portion)

[rmudgett at digium.com]

> On 2010-04-21 12:33:30, Tilghman Lesher wrote:
> > /team/group/ccss/pri.c, lines 1028-1029
> > <https://reviewboard.asterisk.org/r/521/diff/1/?file=8166#file8166line1028>
> >
> >     Add braces to new conditionals, for coding guidelines.

This code was not new.  It was just moved from about 10 lines below.  The red spot just came with it.

I'll add the curly braces.


> On 2010-04-21 12:33:30, Tilghman Lesher wrote:
> > /team/group/ccss/pri_facility.c, line 2410
> > <https://reviewboard.asterisk.org/r/521/diff/1/?file=8168#file8168line2410>
> >
> >     "rsp" to "response".
> >     
> >     There are more, but you get the idea.
> 
> David Vossel wrote:
>     I've noticed that LibPRI seems to have it's own naming standards when it comes to things like this.  rsp seems to be a consistent and widely used abbreviation in LibPRI land.

Most of the abbreviations are to shorten excessively long identifiers.  Also the naming patterns try to indicate a group of functions.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/521/#review1869
-----------------------------------------------------------


On 2010-02-19 15:30:49, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/521/
> -----------------------------------------------------------
> 
> (Updated 2010-02-19 15:30:49)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Added ability to send and receive ETSI Explicit Call Transfer (ECT) messages to eliminate tromboned calls.
> 
> Added ETSI support to an existing API call to send ECT messages when the upper level indicates to transfer specified calls.
> 
> The libpri API was extended to indicate to the upper layer that the far end requests the transfer of the indicated calls.
> 
> This is a two part review request.  Asterisk and libpri.  This is the libpri portion.
> https://reviewboard.asterisk.org/r/520/ is the asterisk portion.
> 
> Note: This change is based off of the libpri/team/group/ccss branch because of needed infrastructure improvements done in that branch.
> 
> 
> Diffs
> -----
> 
>   /team/group/ccss/libpri.h 1499 
>   /team/group/ccss/pri.c 1499 
>   /team/group/ccss/pri_facility.h 1499 
>   /team/group/ccss/pri_facility.c 1499 
>   /team/group/ccss/pri_internal.h 1499 
>   /team/group/ccss/pri_q931.h 1499 
>   /team/group/ccss/q931.c 1499 
> 
> Diff: https://reviewboard.asterisk.org/r/521/diff
> 
> 
> Testing
> -------
> 
> A -- *1 -- *2  -- B&C
> 
> Party A is on an ISDN phone.
> 
> A calls B
> A puts B on hold
> A calls C
> A hangs up to initiate transfer
> The B and C parties are now connected to each other and the calls are only connected through *2.
> 
> A calls B
> A puts B on hold
> A calls C
> A puts C on hold to retrieve B
> A hangs up to initiate transfer
> The B and C parties are now connected to each other and the calls are only connected through *2.
> 
> Repeat the above two tests but party A uses the EctExecute message instead of disconnecting to transfer the calls.
> 
> All four tests passed.
> 
> 
> Thanks,
> 
> rmudgett
> 
>