[asterisk-dev] [Code Review] ETSI Explicit Call Transfer (ECT) support. (libpri portion)

[rmudgett at digium.com]

> On 2010-04-21 14:44:28, David Vossel wrote:
> > /team/group/ccss/pri_facility.c, lines 2430-2438
> > <https://reviewboard.asterisk.org/r/521/diff/1/?file=8168#file8168line2430>
> >
> >     should it be q931_facility(call_2->pri, call_2) ?
> >     
> >     Also, in the past I've noticed that we combine both the queue and the sending of the facility into the same if statement that displays the error message. But I see you did that later in the file so maybe there is a reason for this being different.

In this case it does not matter if it is call->pri or call_2->pri since they should be pointing to the same place.  However, I will make the change to be consistent.

The only effect of not combining the queue and sending is if the diagnostic message is generated.  There really wasn't a reason.  I will also make the change to be consistent.

While making these changes I noticed that the function return value should have been 1 and not zero.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/521/#review1874
-----------------------------------------------------------


On 2010-02-19 15:30:49, rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/521/
> -----------------------------------------------------------
> 
> (Updated 2010-02-19 15:30:49)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Added ability to send and receive ETSI Explicit Call Transfer (ECT) messages to eliminate tromboned calls.
> 
> Added ETSI support to an existing API call to send ECT messages when the upper level indicates to transfer specified calls.
> 
> The libpri API was extended to indicate to the upper layer that the far end requests the transfer of the indicated calls.
> 
> This is a two part review request.  Asterisk and libpri.  This is the libpri portion.
> https://reviewboard.asterisk.org/r/520/ is the asterisk portion.
> 
> Note: This change is based off of the libpri/team/group/ccss branch because of needed infrastructure improvements done in that branch.
> 
> 
> Diffs
> -----
> 
>   /team/group/ccss/libpri.h 1499 
>   /team/group/ccss/pri.c 1499 
>   /team/group/ccss/pri_facility.h 1499 
>   /team/group/ccss/pri_facility.c 1499 
>   /team/group/ccss/pri_internal.h 1499 
>   /team/group/ccss/pri_q931.h 1499 
>   /team/group/ccss/q931.c 1499 
> 
> Diff: https://reviewboard.asterisk.org/r/521/diff
> 
> 
> Testing
> -------
> 
> A -- *1 -- *2  -- B&C
> 
> Party A is on an ISDN phone.
> 
> A calls B
> A puts B on hold
> A calls C
> A hangs up to initiate transfer
> The B and C parties are now connected to each other and the calls are only connected through *2.
> 
> A calls B
> A puts B on hold
> A calls C
> A puts C on hold to retrieve B
> A hangs up to initiate transfer
> The B and C parties are now connected to each other and the calls are only connected through *2.
> 
> Repeat the above two tests but party A uses the EctExecute message instead of disconnecting to transfer the calls.
> 
> All four tests passed.
> 
> 
> Thanks,
> 
> rmudgett
> 
>