[asterisk-dev] [Code Review] Generic Advice of Charge

[David Vossel]

> On 2010-04-15 16:35:24, rmudgett wrote:
> > /team/rmudgett/aoc_event/channels/sig_pri.c, lines 2750-2767
> > <https://reviewboard.asterisk.org/r/552/diff/3/?file=9249#file9249line2750>
> >
> >     A helper routine for currency could be done here and also used for the E routine.

The currency is handled differently in the generic representation.  We don't have a structure to hold it like we do in the subcmd.  A helper function could be made, but it would not have any inverse.  I don't feel very strongly about changing this.


> On 2010-04-15 16:35:24, rmudgett wrote:
> > /team/rmudgett/aoc_event/channels/sig_pri.c, line 2601
> > <https://reviewboard.asterisk.org/r/552/diff/3/?file=9249#file9249line2601>
> >
> >     This can be assigned idx after the for loop rather than incrementing it each time through the loop.

This is an optimization.  I used this same pattern over and over. At times I believe there may have been strict reasons only to increment at certain points.  I may have addressed some of these but I'm not too concerned about looking for these.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/552/#review1842
-----------------------------------------------------------


On 2010-04-20 15:34:37, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/552/
> -----------------------------------------------------------
> 
> (Updated 2010-04-20 15:34:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Asterisk Generic AOC Representation
> - Generic AOC encode/decode routines. (Generic AOC must be encoded to be passed on the wire in the AST_CONTROL_AOC frame)
> - AST_CONTROL_AOC frame type to represent generic encoded AOC data
> - Manager events for AOC-S, AOC-D, and AOC-E messages
> 
> Asterisk App Support
> - app_dial AOC-S pass-through support on call setup
> - app_queue AOC-S pass-through support on call setup
> 
> AOC Unit Tests
> - AOC Unit Tests for encode/decode routines
> - AOC Unit Test for manager event representation.
> 
> SIP AOC Support
> - Pass-through of generic AOC-D and AOC-E messages to snom phones via the snom AOC specification.
> - Creation of chan_sip page3 flags for the addition of the new 'snom_aoc_enabled' sip.conf option.
> 
> IAX AOC Support
> - Natively supports AOC pass-through through the use of the new AST_CONTROL_AOC frame type
> 
> DAHDI AOC Support
> - ETSI PRI full AOC Pass-through support
> - 'aoc_enable' chan_dahdi.conf option for independently enabling pass-through of AOC-S, AOC-D, AOC-E.
> - 'aoce_delayhangup' option for retrieving AOC-E on disconnect.
> - DAHDI A() dial string option for requesting AOC services.
>   example usage: exten=>1111,1,Dial(DAHDI/g1/1112/A(s,d,e)) ;requests AOC-S, AOC-D, and AOC-E on call setup
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/aoc_event/channels/sip/include/sip.h 258188 
>   /team/rmudgett/aoc_event/configs/chan_dahdi.conf.sample 258188 
>   /team/rmudgett/aoc_event/configs/sip.conf.sample 258188 
>   /team/rmudgett/aoc_event/doc/advice_of_charge.txt PRE-CREATION 
>   /team/rmudgett/aoc_event/include/asterisk/aoc.h PRE-CREATION 
>   /team/rmudgett/aoc_event/include/asterisk/frame.h 258188 
>   /team/rmudgett/aoc_event/main/aoc.c PRE-CREATION 
>   /team/rmudgett/aoc_event/apps/app_dial.c 258188 
>   /team/rmudgett/aoc_event/apps/app_queue.c 258188 
>   /team/rmudgett/aoc_event/channels/chan_dahdi.c 258188 
>   /team/rmudgett/aoc_event/channels/chan_sip.c 258188 
>   /team/rmudgett/aoc_event/channels/sig_pri.h 258188 
>   /team/rmudgett/aoc_event/channels/sig_pri.c 258188 
>   /team/rmudgett/aoc_event/main/asterisk.c 258188 
>   /team/rmudgett/aoc_event/main/channel.c 258188 
>   /team/rmudgett/aoc_event/main/features.c 258188 
>   /team/rmudgett/aoc_event/main/manager.c 258188 
>   /team/rmudgett/aoc_event/tests/test_aoc.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/552/diff
> 
> 
> Testing
> -------
> 
> I have tested every feature listed in the description to some extent, but only back to back with Asterisk.   I am going to need some community help to test interoperability.
> 
> To test this code, check out both my Asterisk and Libpri changes.
> 
> Asterisk Changes: svn/asterisk/team/dvossel/generic_aoc
> LibPRI Changes: svn/libpri/team/dvossel/aoc_send 
> 
> 
> Thanks,
> 
> David
> 
>