[asterisk-dev] [Code Review] LibPRI changes for Generic AOC

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/619/
-----------------------------------------------------------

(Updated 2010-04-20 12:51:37.123392)


Review request for Asterisk Developers.


Changes
-------

Update to address the comments I had overlooked on my previous update.


Summary
-------

This review compliments the Asterisk changes in review https://reviewboard.asterisk.org/r/552/.  These are the LibPRI changes required to send ETSI AOC messages generated by Asterisk.


Diffs (updated)
-----

  /team/rmudgett/aoc_event/pri_facility.h 1641 
  /team/rmudgett/aoc_event/pri_facility.c 1641 
  /team/rmudgett/aoc_event/pri_internal.h 1641 
  /team/rmudgett/aoc_event/q931.c 1641 
  /team/rmudgett/aoc_event/libpri.h 1641 
  /team/rmudgett/aoc_event/pri_aoc.c 1641 

Diff: https://reviewboard.asterisk.org/r/619/diff


Testing
-------

These routines have been tested back to back with Asterisk, but I am going to need some community help to test interoperability.

To test this code, check out both my Asterisk and Libpri changes for AOC

Asterisk Changes: svn/asterisk/team/dvossel/generic_aoc
LibPRI Changes: svn/libpri/team/dvossel/aoc_send 


Thanks,

David