[asterisk-dev] [Code Review] Mute / Unmute manager commands for MixMonitor

[Julian Lyndon-Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/487/
-----------------------------------------------------------

(Updated 2010-04-17 15:02:52.840803)


Review request for Asterisk Developers.


Changes
-------

Following OEJ's comments, merged MixMuteMonitor and UnMuteMixMonitor into a single command (MixMonitorMute) with a State option (1=mute, 0=unmute)


Summary
-------

For PCI-DSS compliance we are not allowed to record a credit card number in a MixMonitor file. However, we must record all conversations ....

I have added a new feature to audiohooks so that you can mute either read / write or both types of frames - this allows for MixMonitor to mute either side of the conversation without affecting the conversation itself.

MixMonitor now has two manager commands

1) manager show command MuteMixMonitor
Action: MuteMixMonitor
Synopsis: Mute a channel in MixMonitor
Privilege: <none>
Description: Mutes a Mixmonitor Channel.
Variables:
  Channel: Channel to mute.
  Direction: Which part to mute. read|write|both (from channel|to channel|both channels).

2) manager show command unMuteMixMonitor
Action: unMuteMixMonitor
Synopsis: unMute a channel in MixMonitor
Privilege: <none>
Description: unMutes a Mixmonitor Channel.
Variables:
  Channel: Channel to unmute.
  Direction: Which part to unmute. read|write|both (from channel|to channel|both channels).


This addresses bug 16740.
    https://issues.asterisk.org/view.php?id=16740


Diffs (updated)
-----

  trunk/apps/app_mixmonitor.c 257640 
  trunk/include/asterisk/audiohook.h 257640 
  trunk/include/asterisk/frame.h 257640 
  trunk/main/audiohook.c 257640 
  trunk/main/frame.c 257640 
  trunk/res/res_mutestream.c 257640 

Diff: https://reviewboard.asterisk.org/r/487/diff


Testing
-------

Tested on 1.4 : Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time
Tested on trunk : Tested muting each direction, and both directions, and unmuting, and then listening to the mixmonitor file. The mutes and unmutes all seemed to be in the right place at the right time


Thanks,

Julian