[asterisk-dev] [Code Review] Generic Advice of Charge

Wed Apr 14 18:26:10 CDT 2010

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/552/#review1838
-----------------------------------------------------------

Initial pass through.  Will take a closer look at sig_pri.c, aoc.c, manager.c, and test_aoc.c tomorrow.

/team/rmudgett/aoc_event/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/552/#comment3959>

    For consistency please end the conditional with: #endif /* defined(HAVE_PRI_AOC_EVENTS) */

    Also do this elsewhere in sig_pri.c and sig_pri.h.

/team/rmudgett/aoc_event/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/552/#comment3968>

    Initialize aoc_passthrough_flag to zero here so the user has the ability to disable the option.  Otherwise it is just an accumulation of all values set previously.

/team/rmudgett/aoc_event/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/552/#comment3963>

    It should be a good idea to create a define in sip.h to specify how many flag pages there are?

    Also would it be a good idea to create a macro that copies all page flags?

/team/rmudgett/aoc_event/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/552/#comment3961>

    Indention is not consistent for the current indention level.

/team/rmudgett/aoc_event/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/552/#comment3960>

    Is the switch fall through intentional?  Please add comment to that effect.

/team/rmudgett/aoc_event/channels/sig_pri.h
<https://reviewboard.asterisk.org/r/552/#comment3964>

    These should be SIG_PRI_AOC_... to distinguish them from libpri.h defined values.  Also turning these into an enum would not be a bad idea.

/team/rmudgett/aoc_event/channels/sig_pri.h
<https://reviewboard.asterisk.org/r/552/#comment3966>

    Move this to before inalarm:1 is defined so the bit fields will take up less room.

/team/rmudgett/aoc_event/channels/sig_pri.h
<https://reviewboard.asterisk.org/r/552/#comment3965>

    This information needs to be transferred by pri_fixup_principle().

/team/rmudgett/aoc_event/channels/sig_pri.h
<https://reviewboard.asterisk.org/r/552/#comment3967>

    Move this to before enable_service_message_support:1 is defined so the bit fields will take up less room.

    Also add doxygen comments.

/team/rmudgett/aoc_event/channels/sig_pri.c
<https://reviewboard.asterisk.org/r/552/#comment3969>

    Red spot.

/team/rmudgett/aoc_event/configs/sip.conf.sample
<https://reviewboard.asterisk.org/r/552/#comment3958>

    Use spaces instead of tabs here.

/team/rmudgett/aoc_event/include/asterisk/aoc.h
<https://reviewboard.asterisk.org/r/552/#comment3970>

    Red spots in file.

    I think \since 1.8 should be added to the doxygen function prototypes in this file.

/team/rmudgett/aoc_event/main/manager.c
<https://reviewboard.asterisk.org/r/552/#comment3971>

    Red spot.

- rmudgett

On 2010-04-13 17:43:42, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/552/
> -----------------------------------------------------------
> 
> (Updated 2010-04-13 17:43:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Asterisk Generic AOC Representation
> - Generic AOC encode/decode routines. (Generic AOC must be encoded to be passed on the wire in the AST_CONTROL_AOC frame)
> - AST_CONTROL_AOC frame type to represent generic encoded AOC data
> - Manager events for AOC-S, AOC-D, and AOC-E messages
> 
> Asterisk App Support
> - app_dial AOC-S pass-through support on call setup
> - app_queue AOC-S pass-through support on call setup
> 
> AOC Unit Tests
> - AOC Unit Tests for encode/decode routines
> - AOC Unit Test for manager event representation.
> 
> SIP AOC Support
> - Pass-through of generic AOC-D and AOC-E messages to snom phones via the snom AOC specification.
> - Creation of chan_sip page3 flags for the addition of the new 'snom_aoc_enabled' sip.conf option.
> 
> IAX AOC Support
> - Natively supports AOC pass-through through the use of the new AST_CONTROL_AOC frame type
> 
> DAHDI AOC Support
> - ETSI PRI full AOC Pass-through support
> - 'aoc_enable' chan_dahdi.conf option for independently enabling pass-through of AOC-S, AOC-D, AOC-E.
> - 'aoce_delayhangup' option for retrieving AOC-E on disconnect.
> - DAHDI A() dial string option for requesting AOC services.
>   example usage: exten=>1111,1,Dial(DAHDI/g1/1112/A(s,d,e)) ;requests AOC-S, AOC-D, and AOC-E on call setup
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/aoc_event/apps/app_dial.c 257246 
>   /team/rmudgett/aoc_event/apps/app_queue.c 257246 
>   /team/rmudgett/aoc_event/channels/chan_dahdi.c 257246 
>   /team/rmudgett/aoc_event/channels/chan_sip.c 257246 
>   /team/rmudgett/aoc_event/channels/sig_pri.h 257246 
>   /team/rmudgett/aoc_event/channels/sig_pri.c 257246 
>   /team/rmudgett/aoc_event/channels/sip/include/sip.h 257246 
>   /team/rmudgett/aoc_event/configs/chan_dahdi.conf.sample 257246 
>   /team/rmudgett/aoc_event/configs/sip.conf.sample 257246 
>   /team/rmudgett/aoc_event/include/asterisk/aoc.h PRE-CREATION 
>   /team/rmudgett/aoc_event/include/asterisk/frame.h 257246 
>   /team/rmudgett/aoc_event/main/aoc.c PRE-CREATION 
>   /team/rmudgett/aoc_event/main/asterisk.c 257246 
>   /team/rmudgett/aoc_event/main/channel.c 257246 
>   /team/rmudgett/aoc_event/main/features.c 257246 
>   /team/rmudgett/aoc_event/main/manager.c 257246 
>   /team/rmudgett/aoc_event/tests/test_aoc.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/552/diff
> 
> 
> Testing
> -------
> 
> I have tested every feature listed in the description to some extent, but only back to back with Asterisk.   I am going to need some community help to test interoperability.
> 
> To test this code, check out both my Asterisk and Libpri changes.
> 
> Asterisk Changes: svn/asterisk/team/dvossel/generic_aoc
> LibPRI Changes: svn/libpri/team/dvossel/aoc_send 
> 
> 
> Thanks,
> 
> David
> 
>