[asterisk-dev] [Code Review] Allow quoting and escaping within application options with arguments

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/604/#review1836
-----------------------------------------------------------



/trunk/main/app.c
<https://reviewboard.asterisk.org/r/604/#comment3939>

    Please understand that that is essentially open-coding a common function, which is another no-no in our coding guidelines.  You're suggesting replacing a function call with 8 lines of code that do exactly the same thing.  Code reuse?



/trunk/main/app.c
<https://reviewboard.asterisk.org/r/604/#comment3940>

    I'll add it.


- Tilghman


On 2010-04-14 12:46:49, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/604/
> -----------------------------------------------------------
> 
> (Updated 2010-04-14 12:46:49)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Original description of the issue is:
> 
> f-option of Dial()-application cannot handle '(' or ')' characters in passed CALLERID-parameter
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/app.h 257187 
>   /trunk/main/app.c 257187 
>   /trunk/tests/test_app.c 257187 
> 
> Diff: https://reviewboard.asterisk.org/r/604/diff
> 
> 
> Testing
> -------
> 
> Test written to verify behavior.
> 
> 
> Thanks,
> 
> Tilghman
> 
>