[asterisk-dev] [Code Review] Allow quoting and escaping within application options with arguments

David Vossel dvossel at digium.com
Wed Apr 14 11:24:59 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/604/#review1833
-----------------------------------------------------------


Is there anything different about the parsing logic in both of these functions?  If not, it looks like a good area to create a helper function instead of maintaining the same parsing logic in two places.

- David


On 2010-04-06 12:28:31, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/604/
> -----------------------------------------------------------
> 
> (Updated 2010-04-06 12:28:31)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Original description of the issue is:
> 
> f-option of Dial()-application cannot handle '(' or ')' characters in passed CALLERID-parameter
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/app.h 255795 
>   /trunk/main/app.c 255795 
>   /trunk/tests/test_app.c 255795 
> 
> Diff: https://reviewboard.asterisk.org/r/604/diff
> 
> 
> Testing
> -------
> 
> Test written to verify behavior.
> 
> 
> Thanks,
> 
> Tilghman
> 
>




More information about the asterisk-dev mailing list