[asterisk-dev] [Code Review] Enable 'pri service' commands for DAHDI channels configured for the 'national' switchtype

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/612/#review1827
-----------------------------------------------------------

Ship it!


If testing was successful, the code looks fine to me

- Russell


On 2010-04-09 09:34:13, Dwayne Hubbard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/612/
> -----------------------------------------------------------
> 
> (Updated 2010-04-09 09:34:13)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Revision 1072 of libpri added SERVICE message support for the 'national' switchtype. The attached patch enables the use of 'pri service' CLI commands on DAHDI channels configured for the 'national' switchtype.
> 
> This is related to https://issues.asterisk.org/view.php?id=15803 
> 
> 
> This addresses bug 17142.
>     https://issues.asterisk.org/view.php?id=17142
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_dahdi.c 256484 
> 
> Diff: https://reviewboard.asterisk.org/r/612/diff
> 
> 
> Testing
> -------
> 
> I tested this using back-to-back TE405P spans.  As indicated in the issue tracker, elguero has "been using this new feature since the end of August 2009 without any issues on a NI2 switch.  The CLI commands work as expected for placing the b-channels in and out of service."
> 
> 
> Thanks,
> 
> Dwayne
> 
>