[asterisk-dev] [Code Review] Dynamiclly generate asterisk.conf (new script)
pabelanger at gmail.com
pabelanger at gmail.com
Mon Apr 12 11:52:19 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/616/
-----------------------------------------------------------
(Updated 2010-04-12 11:52:19.772771)
Review request for Asterisk Developers.
Changes
-------
v5: Another fix to sed command. Removed -r flag, cleaned up pattern matching. Thanks seanbright.
Summary
-------
A new script to dynamically generate asterisk.conf. This simply moves the functionality from the Makefile (cleaning it up) into an external script. However, I would like to enhance 'make_asterisk_conf' allow a user to make dynamic changes to the static configuration. IE: toggle settings, override '(!)' flag.
I have also made some formatting (easier to read) and grammar changes to 'asterisk.conf'.
This addresses bug 17027.
https://issues.asterisk.org/view.php?id=17027
Diffs (updated)
-----
/trunk/Makefile 256823
/trunk/configs/asterisk.conf.sample PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/616/diff
Testing
-------
On local development and QA box; More portability testing required.
Thanks,
pabelanger
More information about the asterisk-dev
mailing list