[asterisk-dev] [asterisk-commits] dvossel: trunk r256319 - /trunk/channels/chan_sip.c

[David Vossel]

----- "Russell Bryant" <russell at digium.com> wrote:
> 
> What guarantees that owner is a valid channel in this code?  Based on
> my reading, there is nothing that guarantees that the channel will not
> get freed out from under this code.  A reference needs to be taken on
> p->owner before the unlocks to resolve this.
> 
> --
> Russell Bryant
> Digium, Inc.  |  Engineering Manager, Open Source Software
> 445 Jan Davis Drive NW   -    Huntsville, AL 35806  -  USA
> jabber: rbryant at digium.com    -=-    skype: russell-bryant
> www.digium.com -=- www.asterisk.org -=- blogs.asterisk.org

Fixed in r256823.  For some reason I was under the impression the owner got locked and a reference in handle_request_do(), but this is not the case.

~Vossel