[asterisk-dev] [Code Review] External tests for func_srv and explicit SIP outgoing destination

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/609/
-----------------------------------------------------------

(Updated 2010-04-09 16:24:38.277008)


Review request for Asterisk Developers.


Changes
-------

I made a few changes to the sip_outbound_address test.

* Instead of having a bunch of nearly identical SIPp UAC files. I now just use a manager originate to a local channel.
* I added an explicit "pass" variable. I noticed that sometimes when I would run the test, the test would pass because, well, nothing would happen. Now, the proper impetus must set the "pass" variable to true in order for the test to pass.


Summary
-------

Two new external tests for Asterisk, meant to exercise the new code added in review 608.

The first has a simple dialplan that queries for known SRV records and then compares what is returned to what we expect to have been returned. This simultaneously exercises the ordering of SRV records by ast_srv_lookup while also testing the validity of the data retrieved by SRVQUERY and SRVRESULT.

The second runs several test calls through a dialplan that formats some SIP dialstrings quite differently. For each iteration of the test, we run two SIPp UAS scenarios. One is the UAS that is reached if using the parameters from sip.conf, and the other is the one that is reached if we override the destination in the dialstring. Each UAS will answer the call and send a specific DTMF digit. We read this digit and based on which digit we receive, we can determine if the proper UAS answered.


Diffs (updated)
-----

  /asterisk/trunk/tests/func_srv/configs/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/func_srv/run-test PRE-CREATION 
  /asterisk/trunk/tests/func_srv/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/func_srv/test.lua PRE-CREATION 
  /asterisk/trunk/tests/sip_outbound_address/configs/extensions.conf PRE-CREATION 
  /asterisk/trunk/tests/sip_outbound_address/configs/sip.conf PRE-CREATION 
  /asterisk/trunk/tests/sip_outbound_address/run-test PRE-CREATION 
  /asterisk/trunk/tests/sip_outbound_address/sipp/dtmf_2833_1.pcap UNKNOWN 
  /asterisk/trunk/tests/sip_outbound_address/sipp/dtmf_2833_2.pcap UNKNOWN 
  /asterisk/trunk/tests/sip_outbound_address/sipp/dtmf_2833_pound.pcap UNKNOWN 
  /asterisk/trunk/tests/sip_outbound_address/sipp/uas1.xml PRE-CREATION 
  /asterisk/trunk/tests/sip_outbound_address/sipp/uas2.xml PRE-CREATION 
  /asterisk/trunk/tests/sip_outbound_address/test-config.yaml PRE-CREATION 
  /asterisk/trunk/tests/sip_outbound_address/test.lua PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/609/diff


Testing
-------

The tests both pass.


Thanks,

Mark