[asterisk-dev] [Code Review] IAXpeers output now matches SIPpeers format for manager.

Tilghman Lesher tlesher at digium.com
Wed Apr 7 12:32:33 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/594/#review1814
-----------------------------------------------------------

Ship it!


This also needs notes in CHANGES and UPGRADE.txt, noting that the manager format changed.  Otherwise, good work.

- Tilghman


On 2010-03-26 14:40:07, pabelanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/594/
> -----------------------------------------------------------
> 
> (Updated 2010-03-26 14:40:07)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> I made changes to IAXpeers and made it similar to the expected output of SIPpeers.  I followed the formatting and logic from chan_sip.c, and want to confirm I did it right.
> 
> 
> This addresses bug 17100.
>     https://issues.asterisk.org/view.php?id=17100
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_iax2.c 254973 
> 
> Diff: https://reviewboard.asterisk.org/r/594/diff
> 
> 
> Testing
> -------
> 
> local testing to with my development box and test server.
> 
> 
> Thanks,
> 
> pabelanger
> 
>




More information about the asterisk-dev mailing list