[asterisk-dev] [Code Review] fixes deadlock in chan_sip caused by use of MASTER_CHANNEL() dialplan function

David Vossel dvossel at digium.com
Mon Apr 5 17:10:54 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/606/
-----------------------------------------------------------

Review request for Asterisk Developers and Tilghman Lesher.


Summary
-------

The use of the MASTER_CHANNEL() dialplan function in chan_sip currently causes a deadlock as it invalidates channel container locking order. This patch uses a taskprocessor in chan_sip to push the task of using pbx setvar on MASTER_CHANNEL() to a separate thread.


Diffs
-----

  /trunk/channels/chan_sip.c 256218 

Diff: https://reviewboard.asterisk.org/r/606/diff


Testing
-------

made sip calls, verified items were being pushed and processed by the taskprocessor.


Thanks,

David




More information about the asterisk-dev mailing list