[asterisk-dev] [Code Review] Allow quoting and escaping within application options with arguments

Tilghman Lesher tlesher at digium.com
Mon Apr 5 00:05:00 CDT 2010



> On 2010-04-02 19:08:45, Russell Bryant wrote:
> > /trunk/main/app.c, line 1843
> > <https://reviewboard.asterisk.org/r/604/diff/1/?file=9094#file9094line1843>
> >
> >     The manpage for strcpy() says that the strings must not overlap.

Changed to utilize memccpy() (C99 and POSIX 2004).


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/604/#review1800
-----------------------------------------------------------


On 2010-04-05 00:03:51, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/604/
> -----------------------------------------------------------
> 
> (Updated 2010-04-05 00:03:51)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Original description of the issue is:
> 
> f-option of Dial()-application cannot handle '(' or ')' characters in passed CALLERID-parameter
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/app.h 255795 
>   /trunk/main/app.c 255795 
>   /trunk/tests/test_app.c 255795 
> 
> Diff: https://reviewboard.asterisk.org/r/604/diff
> 
> 
> Testing
> -------
> 
> Test written to verify behavior.
> 
> 
> Thanks,
> 
> Tilghman
> 
>




More information about the asterisk-dev mailing list