[asterisk-dev] [Code Review] Add an option to restore past broken behavor of the Events manager action

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/602/#review1798
-----------------------------------------------------------

Ship it!


- Russell


On 2010-04-02 14:29:29, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/602/
> -----------------------------------------------------------
> 
> (Updated 2010-04-02 14:29:29)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Recently (in January) the behavior of the Events manager action changed. Before r238915, certain values for the EventMask parameter of the Events action would result in no response being returned.  This patch adds an option to restore that broken behavior.  Also while fixing this bug I discovered that passing an empty EventMasks parameter would also result in no response being returned, this has been fixed as well while being preserved when the broken behavior is requested.
> 
> 
> This addresses bug 17023.
>     https://issues.asterisk.org/view.php?id=17023
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/configs/manager.conf.sample 255892 
>   /branches/1.4/main/manager.c 255892 
> 
> Diff: https://reviewboard.asterisk.org/r/602/diff
> 
> 
> Testing
> -------
> 
> Tested with the external test in review 603 https://reviewboard.asterisk.org/r/603/.  That test sends various values for EventMask with the brokeneventsaction enabled and disabled.
> 
> 
> Thanks,
> 
> Matthew
> 
>