[asterisk-dev] [Code Review] A python AsteriskCSVCDR library for testing csv cdrs

Terry Wilson twilson at digium.com
Fri Apr 2 18:36:29 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/605/
-----------------------------------------------------------

(Updated 2010-04-02 18:36:29.081975)


Review request for Asterisk Developers and Russell Bryant.


Changes
-------

Address Russell's comments.


Summary
-------

This is a library that adds the ability to test the CDRs that are generated during a test.  It can read a list of CDRs in from cdr-csv file, and test that the fields match some given input.

I have also added CDR parsing to the iax-basic-call test. I'll correct the trailing whitespace that I see that crept in. :-)


Diffs (updated)
-----

  /asterisk/trunk/lib/python/asterisk/cdr.py PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/self_test/Master.csv PRE-CREATION 
  /asterisk/trunk/lib/python/asterisk/self_test/Master2.csv PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/605/diff


Testing
-------

There is some internal testing done and I have run the iax-basic-call test and verified that it works on trunk and branches/1.4. On 1.4.26.2, the iax-basic-call test fails because no Master.csv file is created for some reason.


Thanks,

Terry




More information about the asterisk-dev mailing list