[asterisk-dev] [Code Review] Added mohsuggest info to output for CLI: sip show peer {name}

Olle E Johansson oej at edvina.net
Tue Sep 29 13:39:02 CDT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/381/#review1119
-----------------------------------------------------------


You need to add it to the manager part too.

Thanks.

- Olle E


On 2009-09-29 12:07:58, _brent_ wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/381/
> -----------------------------------------------------------
> 
> (Updated 2009-09-29 12:07:58)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> the CLI command:
> 
>     sip show peer {name}
> 
> now outputs information about the peer's mohsuggest setting in addition to all the other stuff already being printed. Looks like this:
> 
> ...
> Pickupgroup :
> MOH Suggest : Rockout
> Mailbox : 7112 at default
> ... 
> 
> 
> This addresses bug 0015990.
>     https://issues.asterisk.org/view.php?id=0015990
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 220823 
> 
> Diff: https://reviewboard.asterisk.org/r/381/diff
> 
> 
> Testing
> -------
> 
> Added it, built it, ran it. It works. This doesn't really change any core functionality. It just adds one line to some CLI informational output. Is there anything else I should test?
> 
> 
> Thanks,
> 
> _brent_
> 
>




More information about the asterisk-dev mailing list