[asterisk-dev] [Code Review] Added ability to specify different SIP and media addresses

[Jared Smith]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/377/#review1116
-----------------------------------------------------------

Ship it!


Looks good to me... I'm not a hard-core developer, but this patch is simple enough that even I can understand it.  It's got my vote (for what it's worth)

- Jared


On 2009-09-23 15:54:16, _brent_ wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/377/
> -----------------------------------------------------------
> 
> (Updated 2009-09-23 15:54:16)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Added media_address setting to chan_sip. Enabled by setting
> 
> media_address=x.x.x.x
> 
> in sip.conf. This should be particularly useful to anyone running Asterisk behind a SIP proxy, like OpenSER/OpenSIPS/Kamailio. This patch allows Asterisk to report its externip (again, set in sip.conf) as the proxy's IP address, but its media address as its own to bypass the proxy.
> 
> 
> This addresses bug 0014729.
>     https://issues.asterisk.org/view.php?id=0014729
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 219939 
> 
> Diff: https://reviewboard.asterisk.org/r/377/diff
> 
> 
> Testing
> -------
> 
> * Configured on Asterisk running on private IP addr only, behind router/firewall forwarding pub IP to private IP.
> * Sniffed traffic and SDP is correct per configuration.
> * Running for 6 months w/o issue.
> 
> 
> Thanks,
> 
> _brent_
> 
>