[asterisk-dev] [Code Review] New application JabberReceive, implement SendText in chan_gtalk and chan_jingle

[Philippe Sultan]

> On 2009-09-18 15:10:16, Jeff Peeler wrote:
> > I believe these are the only changes left, but given how the diffs are unreadable can you double check and make sure you implemented the above improvements? Then merge the changes to your branch so that merging is easier.

Yes, the modification Russell asked for have been integrated.

The corresponding branch is indeed not updated, but since the diff I obtained from it became unreadable by the reviewboard web interface, I'd rather stick with those uploaded diff files and eventually commit the changes myself if you confirm they're fine.

Thanks for the review Jeff!


> On 2009-09-18 15:10:16, Jeff Peeler wrote:
> > /trunk/res/res_jabber.c, line 686
> > <https://reviewboard.asterisk.org/r/88/diff/8/?file=6382#file6382line686>
> >
> >     no space before function args

Ok.


> On 2009-09-18 15:10:16, Jeff Peeler wrote:
> > /trunk/res/res_jabber.c, line 706
> > <https://reviewboard.asterisk.org/r/88/diff/8/?file=6382#file6382line706>
> >
> >     looks like you still need to stop autoservice when returning due to an error

I moved the call to ast_autoservice_start accordingly. 


- Philippe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/88/#review1099
-----------------------------------------------------------


On 2009-09-23 03:26:05, Philippe Sultan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/88/
> -----------------------------------------------------------
> 
> (Updated 2009-09-23 03:26:05)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> JabberReceive is a dialplan application that makes Asterisk wait for an XMPP message from a given user (identified with his JID), and store the content in a dialplan variable.
> 
> It can be used for example to notify a user (via XMPP) that a call is coming, and read input back from him.
> Taken from the documentation :
> In the following example, calls targeted to extension 1234 (be it 
> accessed from SIP, DAHDI or whatever channel type) are controlled by
> user bob at jabber.org. Asterisk notifies him that a call is coming, and
> asks him to take an action. This dialog takes place over an XMPP chat.
> 
> context from-ext {
> 	1234 => {
> 		Answer();
> 		JabberSend(asterisk-xmpp,bob at jabber.org,Call from $CALLERID(num) - choose an option to process the call);
> 		JabberSend(asterisk-xmpp,bob at jabber.org,1 : forward to cellphone);
> 		JabberSend(asterisk-xmpp,bob at jabber.org,2 : forward to work phone);
> 		JabberSend(asterisk-xmpp,bob at jabber.org,Default action : forward to your voicemail);
> 		JabberReceive(bob at jabber.org,OPTION,20);
> 		switch (${OPTION}) {
> 			case 1:
> 	  			JabberSend(asterisk-xmpp,bob at jabber.org,(Calling cellphone...);
> 				Dial(SIP/987654321);
> 				break;
> 			case 2:
> 				JabberSend(asterisk-xmpp,bob at jabber.org,(Calling workphone...);
> 				Dial(SIP/${EXTEN});
> 				break;
> 			default:
> 				Voicemail(${EXTEN}|u)
> 		}
> 	}
> }
> 
> The diff also includes an implementation of SendText as XMPP messages in both chan_jingle and chan_gtalk.
> 
> The corresponding bug contains more use cases : http://bugs.digium.com/view.php?id=12569
> 
> 
> This addresses bug 12569.
>     https://issues.asterisk.org/view.php?id=12569
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 219891 
>   /trunk/channels/chan_gtalk.c 219891 
>   /trunk/channels/chan_jingle.c 219891 
>   /trunk/configs/jabber.conf.sample 219891 
>   /trunk/doc/jabber.txt 219891 
>   /trunk/include/asterisk/jabber.h 219891 
>   /trunk/res/res_jabber.c 219891 
> 
> Diff: https://reviewboard.asterisk.org/r/88/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Philippe
> 
>