[asterisk-dev] [Code Review] SIP: peer matching by address with TCP/TLS

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/354/#review1056
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/354/#comment2590>

    You are changing the behaviour of this code in an important way.  With the change you made, it will match a peer with insecure=port set on the first pass.  The intention is that we consider all appropriate peers without doing the insecure=port check first, before trying again for a less specific match.


- Russell


On 2009-09-04 12:29:10, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/354/
> -----------------------------------------------------------
> 
> (Updated 2009-09-04 12:29:10)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Using both the ip address and port number to peer match a connection coming in over tcp does not work.  A work around for this issue was committed a few months ago which used the contact header to peer match tcp connections. This is incorrect.  Instead, peer matching for tcp connections should be done by ip address only.
> 
> This patch removes the contact header matching logic and adds logic to match all tcp/tls connections by ip only.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 216506 
> 
> Diff: https://reviewboard.asterisk.org/r/354/diff
> 
> 
> Testing
> -------
> 
> tested invites over tcp, verified peer matching by ip works correctly.
> 
> 
> Thanks,
> 
> David
> 
>