[asterisk-dev] [Code Review] Dynamic parking lots

[Michiel van Baak]

> On 2009-09-03 13:45:37, Sean Bright wrote:
> > Other than a few minor comments, this looks good to me.

Thanks.
I altered the patch to address your comments.
I'm going to give the patch to igorg and acunningham for one final test before commit.


> On 2009-09-03 13:45:37, Sean Bright wrote:
> > /trunk/configs/features.conf.sample, line 30
> > <https://reviewboard.asterisk.org/r/352/diff/3/?file=6335#file6335line30>
> >
> >     It looks like the other comments in this file are spaced over using spaces and not tabs.  Might want to be consistent.  (This might just be showing up strange in reviewboard, however)

only the couple right above this one.
The rest is using tabs as well.

I'll leave it like this and fix all of them in a seperate commit


> On 2009-09-03 13:45:37, Sean Bright wrote:
> > /trunk/main/features.c, lines 152-159
> > <https://reviewboard.asterisk.org/r/352/diff/3/?file=6336#file6336line152>
> >
> >     This text could use some re-working.  Some of it doesn't make sense and it's missing some punctuation.

done


> On 2009-09-03 13:45:37, Sean Bright wrote:
> > /trunk/main/features.c, line 304
> > <https://reviewboard.asterisk.org/r/352/diff/3/?file=6336#file6336line304>
> >
> >     dynamicaly -> dynamically

done


> On 2009-09-03 13:45:37, Sean Bright wrote:
> > /trunk/main/features.c, line 376
> > <https://reviewboard.asterisk.org/r/352/diff/3/?file=6336#file6336line376>
> >
> >     You should probably give the second argument a name for consistency.

done


> On 2009-09-03 13:45:37, Sean Bright wrote:
> > /trunk/main/features.c, lines 655-657
> > <https://reviewboard.asterisk.org/r/352/diff/3/?file=6336#file6336line655>
> >
> >     Add spaces before the "" in these lines.

done


> On 2009-09-03 13:45:37, Sean Bright wrote:
> > /trunk/main/features.c, line 702
> > <https://reviewboard.asterisk.org/r/352/diff/3/?file=6336#file6336line702>
> >
> >     Space before the "".

done


- Michiel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/352/#review1053
-----------------------------------------------------------


On 2009-09-02 15:59:58, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/352/
> -----------------------------------------------------------
> 
> (Updated 2009-09-02 15:59:58)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This pathc intended to introduce fully dynamic parking. As requested in bounty variables PARKINGEXTEN and PARKINGLOT can be defined anywhere in dialplan or AGI and parking lot not defined in features.conf. On call park new parking lot 'll be created based on default lot settings or settings of parkinglot from PARKINGDYNAMIC variable.
> 
> Also variables PARKINGDYNCONTEXT and PARKINGDYNPOS introduce to control parking context and positions of newly created parking lot.
> 
> New behavior controlled by setting 'parkeddynamic' in features.conf 
> 
> 
> This addresses bug 15135.
>     https://issues.asterisk.org/view.php?id=15135
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/features.conf.sample 215647 
>   /trunk/main/features.c 215647 
> 
> Diff: https://reviewboard.asterisk.org/r/352/diff
> 
> 
> Testing
> -------
> 
> Added the variables in dialplan, setup call, parked, and verified it ended up in the parkinglot. parkinglot was not added to features.conf. Also retrieved the call again.
> 
> IgorG and acunningham reported success as well
> 
> 
> Thanks,
> 
> Michiel
> 
>