[asterisk-dev] [Code Review] Dynamic parking lots

Michiel van Baak michiel at vanbaak.info
Wed Sep 2 15:59:58 CDT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/352/
-----------------------------------------------------------

(Updated 2009-09-02 15:59:58.131626)


Review request for Asterisk Developers.


Changes
-------

Addressed Sean's remarks


Summary
-------

This pathc intended to introduce fully dynamic parking. As requested in bounty variables PARKINGEXTEN and PARKINGLOT can be defined anywhere in dialplan or AGI and parking lot not defined in features.conf. On call park new parking lot 'll be created based on default lot settings or settings of parkinglot from PARKINGDYNAMIC variable.

Also variables PARKINGDYNCONTEXT and PARKINGDYNPOS introduce to control parking context and positions of newly created parking lot.

New behavior controlled by setting 'parkeddynamic' in features.conf 


This addresses bug 15135.
    https://issues.asterisk.org/view.php?id=15135


Diffs (updated)
-----

  /trunk/configs/features.conf.sample 215647 
  /trunk/main/features.c 215647 

Diff: https://reviewboard.asterisk.org/r/352/diff


Testing
-------

Added the variables in dialplan, setup call, parked, and verified it ended up in the parkinglot. parkinglot was not added to features.conf. Also retrieved the call again.

IgorG and acunningham reported success as well


Thanks,

Michiel




More information about the asterisk-dev mailing list