[asterisk-dev] [Code Review] Dynamic parking lots

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/352/#review1048
-----------------------------------------------------------



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/352/#comment2567>

    Space after if



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/352/#comment2568>

    This should have the same scanf() changes as Tilghman committed a few months ago (i.e. %30d instead of %d)



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/352/#comment2566>

    This looks like a bug-fix.  Should probably go in as a separate commit.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/352/#comment2565>

    I'm not sure if this is needed, but shouldn't the linked list of parked calls (parkings member of ast_parkinglog) be reset/initialized as well?


- Sean


On 2009-09-02 11:53:42, Michiel van Baak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/352/
> -----------------------------------------------------------
> 
> (Updated 2009-09-02 11:53:42)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This pathc intended to introduce fully dynamic parking. As requested in bounty variables PARKINGEXTEN and PARKINGLOT can be defined anywhere in dialplan or AGI and parking lot not defined in features.conf. On call park new parking lot 'll be created based on default lot settings or settings of parkinglot from PARKINGDYNAMIC variable.
> 
> Also variables PARKINGDYNCONTEXT and PARKINGDYNPOS introduce to control parking context and positions of newly created parking lot.
> 
> New behavior controlled by setting 'parkeddynamic' in features.conf 
> 
> 
> This addresses bug 15135.
>     https://issues.asterisk.org/view.php?id=15135
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/features.conf.sample 215512 
>   /trunk/main/features.c 215512 
> 
> Diff: https://reviewboard.asterisk.org/r/352/diff
> 
> 
> Testing
> -------
> 
> Added the variables in dialplan, setup call, parked, and verified it ended up in the parkinglot. parkinglot was not added to features.conf. Also retrieved the call again.
> 
> IgorG and acunningham reported success as well
> 
> 
> Thanks,
> 
> Michiel
> 
>