[asterisk-dev] [Code Review] SIP uri parsing cleanup

David Vossel dvossel at digium.com
Wed Sep 2 12:26:29 CDT 2009



> On 2009-09-02 09:59:11, Russell Bryant wrote:
> > /trunk/channels/chan_sip.c, lines 12364-12368
> > <https://reviewboard.asterisk.org/r/343/diff/2/?file=6324#file6324line12364>
> >
> >     Should we use sscanf() here to check for conversion errors?

I agree.  There are several places where atoi(pt) is used where sscanf would be more appropriate.  I'll follow up with a separate commit to address all of these.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/343/#review1046
-----------------------------------------------------------


On 2009-09-02 09:36:45, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/343/
> -----------------------------------------------------------
> 
> (Updated 2009-09-02 09:36:45)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Originally anytime parse_uri() was used it first had to be passed the "sip" scheme, then if that failed it had to be passed the "sips" scheme.  This required two identical uri buffers. Now parse_uri can just be called once with a single buffer.  This patch also addresses an issue where the "transport=" field of a uri was not being handled correctly.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 215151 
> 
> Diff: https://reviewboard.asterisk.org/r/343/diff
> 
> 
> Testing
> -------
> 
> compiles, registers, makes calls..
> 
> 
> Thanks,
> 
> David
> 
>




More information about the asterisk-dev mailing list