[asterisk-dev] [Code Review] Add mutestream manager action and MUTESTREAM() dialplan function

[Olle E Johansson]

> On 2009-09-01 13:57:52, Russell Bryant wrote:
> > ./res/res_mutestream.c, lines 19-25
> > <https://reviewboard.asterisk.org/r/345/diff/4/?file=6320#file6320line19>
> >
> >     I suppose you could add "\ingroup functions" here.

Done.


> On 2009-09-01 13:57:52, Russell Bryant wrote:
> > ./res/res_mutestream.c, line 235
> > <https://reviewboard.asterisk.org/r/345/diff/4/?file=6320#file6320line235>
> >
> >     space after if

Done


> On 2009-09-01 13:57:52, Russell Bryant wrote:
> > ./res/res_mutestream.c, line 240
> > <https://reviewboard.asterisk.org/r/345/diff/4/?file=6320#file6320line240>
> >
> >     little bit of trailing whitespace

Removed


> On 2009-09-01 13:57:52, Russell Bryant wrote:
> > ./res/res_mutestream.c, line 311
> > <https://reviewboard.asterisk.org/r/345/diff/4/?file=6320#file6320line311>
> >
> >     space after if

Move from line 240.


> On 2009-09-01 13:57:52, Russell Bryant wrote:
> > ./res/res_mutestream.c, lines 327-333
> > <https://reviewboard.asterisk.org/r/345/diff/4/?file=6320#file6320line327>
> >
> >     I would declare this as "static const char"  (add const)

Done


> On 2009-09-01 13:57:52, Russell Bryant wrote:
> > ./res/res_mutestream.c, line 343
> > <https://reviewboard.asterisk.org/r/345/diff/4/?file=6320#file6320line343>
> >
> >     whitespace

Extra spare buffer to use between if and (


> On 2009-09-01 13:57:52, Russell Bryant wrote:
> > ./res/res_mutestream.c, lines 31-37
> > <https://reviewboard.asterisk.org/r/345/diff/4/?file=6320#file6320line31>
> >
> >     These are probably not needed.

Removed.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/345/#review1041
-----------------------------------------------------------


On 2009-09-01 13:31:07, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/345/
> -----------------------------------------------------------
> 
> (Updated 2009-09-01 13:31:07)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When you need to be able to mute incoming or outgoing audio for a channel, this is the function you need.
> 
> I am a bit unsure of the unload functionality. What will happen if I unload an audiohook module when a channel is active? 
> 
> This work is inspired by app_jack.c and func_volume.c
> 
> 
> Diffs
> -----
> 
>   ./res/res_mutestream.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/345/diff
> 
> 
> Testing
> -------
> 
> I've tested this in manager and with the dynamic features in features.conf.
> 
> 
> Thanks,
> 
> Olle E
> 
>