[asterisk-dev] [Code Review] Add service message support for the 'national' switchtype

[Kevin Fleming]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/347/#review1035
-----------------------------------------------------------

Ship it!


Looks OK to me. I'm not thrilled about NATIONAL_SERVICE/_ACKNOWLEDGE changing values like this, but since it's an internal libpri header it's acceptable.

- Kevin


On 2009-08-31 14:49:31, Dwayne Hubbard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/347/
> -----------------------------------------------------------
> 
> (Updated 2009-08-31 14:49:31)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Extended libpri service message support to correctly handle 'national' switchtype service messages.
> 
> Loosened chan_dahdi configuration restriction to allow the enabling of service_message_support when configured for the 'national' switchtype
> 
> development branches:
> https://origsvn.digium.com/svn/libpri/team/dhubbard/bbfcfm
> https://origsvn.digium.com/svn/asterisk/team/dhubbard/bbfcfm
> 
> 
> This addresses bug https://issues.asterisk.org/view.php?id=15803.
>     http://issues.asterisk.org/view.php?id=https://issues.asterisk.org/view.php?id=15803
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/pri_q931.h 1050 
>   /branches/1.4/q931.c 1050 
> 
> Diff: https://reviewboard.asterisk.org/r/347/diff
> 
> 
> Testing
> -------
> 
> Michael Young (IRC nick: elguero) successfully tested on a live NI-2 switch
> 
> Tested Branch Revisions:
> https://origsvn.digium.com/svn/libpri/team/dhubbard/bbfcfm [^] r1039
> https://origsvn.digium.com/svn/asterisk/team/dhubbard/bbfcfm [^] r214818
> 
> Results:
> In the quote below, "maintenance mode == 'pri service disable'"
> 
> Quote Michael Young:
> 
> 1. I placed all the calls into maintenance mode. I tried calling in and
> received the message that the call could not go through.
> 
> 2. I placed one channel out of maintenance mode and tried again resulting in the call going through like it should. I tried another call (while keeping that channel up) and received the message again.
> 
> 3. I placed another channel out of maintenance mode and placed another call resulting in it going through as well.
> 
> 4. I then proceeded to put the rest of the channels out of maintenance mode and everything looked like it was back to normal. 
> 
> 
> Thanks,
> 
> Dwayne
> 
>