[asterisk-dev] [Code Review] Add mutestream manager action and MUTESTREAM() dialplan function

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/345/#review1033
-----------------------------------------------------------


We're close.  :-)


./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2531>

    missing channel unlock here



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2532>

    For the "Assumes that the channel is locked" comment, you could use the "\pre" doxygen tag if you'd like.  "\pre" is for stating a pre-condition for a function, which is something that must be true before the function is called.
    
    Similarly, there is also a "\post" tag for documenting a post-condition.



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2533>

    If mute_add_audiohook() fails, should we just destroy the datastore and audiohook data here?



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2534>

    If either of this interface registrations fail, we should probably return AST_MODULE_LOAD_DECLINE.



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2535>

    There is nothing wrong with this, but after the changes you have made, it is now equivalent to AST_MODULE_INFO_STANDARD(), which is just a little bit less code.


- Russell


On 2009-09-01 10:02:06, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/345/
> -----------------------------------------------------------
> 
> (Updated 2009-09-01 10:02:06)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When you need to be able to mute incoming or outgoing audio for a channel, this is the function you need.
> 
> I am a bit unsure of the unload functionality. What will happen if I unload an audiohook module when a channel is active? 
> 
> This work is inspired by app_jack.c and func_volume.c
> 
> 
> Diffs
> -----
> 
>   ./res/res_mutestream.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/345/diff
> 
> 
> Testing
> -------
> 
> I've tested this in manager and with the dynamic features in features.conf.
> 
> 
> Thanks,
> 
> Olle E
> 
>