[asterisk-dev] [Code Review] Add mutestream manager action and MUTESTREAM() dialplan function

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/345/#review1030
-----------------------------------------------------------



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2517>

    The lock actually needs to be held around datastore_find(), as well.



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2518>

    This is pretty picky, but I would prefer "id_text" to be consistent with our naming conventions.



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2519>

    You're missing a channel unlock here



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2520>

    The unlock has to come before the unref.  By saying "unref", you have given up your reference to the channel and can not touch it again.



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2521>

    I suppose we could just remove reload() for this module.



./res/res_mutestream.c
<https://reviewboard.asterisk.org/r/345/#comment2522>

    I don't think this module exports any functions, does it?  If it doesn't, then you will want to not set MODFLAG_GLOBAL_SYMBOLS.  


- Russell


On 2009-08-31 13:50:43, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/345/
> -----------------------------------------------------------
> 
> (Updated 2009-08-31 13:50:43)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> When you need to be able to mute incoming or outgoing audio for a channel, this is the function you need.
> 
> I am a bit unsure of the unload functionality. What will happen if I unload an audiohook module when a channel is active? 
> 
> This work is inspired by app_jack.c and func_volume.c
> 
> 
> Diffs
> -----
> 
>   ./res/res_mutestream.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/345/diff
> 
> 
> Testing
> -------
> 
> I've tested this in manager and with the dynamic features in features.conf.
> 
> 
> Thanks,
> 
> Olle E
> 
>