[asterisk-dev] [Code Review] Expand availability of codec bits from 32 to 64

Tilghman Lesher tlesher at digium.com
Fri Oct 30 00:58:48 CDT 2009 


> On 2009-10-29 11:48:19, vadim wrote:
> > /trunk/include/asterisk/frame.h, line 705
> > <https://reviewboard.asterisk.org/r/416/diff/2/?file=7122#file7122line705>
> >
> >     I think this could be more efficent:
> >     
> >      if (format & 
> >         (AST_FORMAT_G722 AST_FORMAT_SIREN7 | AST_FORMAT_SLINEAR16))
> >          return 16000;
> >       if (format == AST_FORMAT_SIREN14)
> >          return 32000;
> >     
> >       return 8000;
> >       |

I don't think that's true.  With compiler optimization, it's likely that either set of code will produce the same result.  In any case, it's of little relevance to the code conversion of note here.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/416/#review1222
-----------------------------------------------------------


On 2009-10-28 15:43:01, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/416/
> -----------------------------------------------------------
> 
> (Updated 2009-10-28 15:43:01)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Since the addition of SIREN7 and SIREN14 codecs, there are 0 audio codec bits left in which to allocate more codecs.  This implementation adds an additional 16 audio bits.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_alarmreceiver.c 226383 
>   /trunk/apps/app_amd.c 226383 
>   /trunk/apps/app_chanspy.c 226383 
>   /trunk/apps/app_dahdibarge.c 226383 
>   /trunk/apps/app_dial.c 226383 
>   /trunk/apps/app_dictate.c 226383 
>   /trunk/apps/app_disa.c 226383 
>   /trunk/apps/app_echo.c 226383 
>   /trunk/apps/app_externalivr.c 226383 
>   /trunk/apps/app_fax.c 226383 
>   /trunk/apps/app_festival.c 226383 
>   /trunk/apps/app_followme.c 226383 
>   /trunk/apps/app_meetme.c 226383 
>   /trunk/apps/app_milliwatt.c 226383 
>   /trunk/apps/app_mp3.c 226383 
>   /trunk/apps/app_nbscat.c 226383 
>   /trunk/apps/app_queue.c 226383 
>   /trunk/apps/app_record.c 226383 
>   /trunk/apps/app_sms.c 226383 
>   /trunk/apps/app_speech_utils.c 226383 
>   /trunk/apps/app_talkdetect.c 226383 
>   /trunk/apps/app_test.c 226383 
>   /trunk/apps/app_url.c 226383 
>   /trunk/apps/app_waitforring.c 226383 
>   /trunk/bridges/bridge_softmix.c 226383 
>   /trunk/channels/chan_agent.c 226383 
>   /trunk/channels/chan_alsa.c 226383 
>   /trunk/channels/chan_bridge.c 226383 
>   /trunk/channels/chan_console.c 226383 
>   /trunk/channels/chan_dahdi.c 226383 
>   /trunk/channels/chan_gtalk.c 226383 
>   /trunk/channels/chan_h323.c 226383 
>   /trunk/channels/chan_iax2.c 226383 
>   /trunk/channels/chan_jingle.c 226383 
>   /trunk/channels/chan_local.c 226383 
>   /trunk/channels/chan_mgcp.c 226383 
>   /trunk/channels/chan_misdn.c 226383 
>   /trunk/channels/chan_multicast_rtp.c 226383 
>   /trunk/channels/chan_oss.c 226383 
>   /trunk/channels/chan_phone.c 226383 
>   /trunk/channels/chan_sip.c 226383 
>   /trunk/channels/chan_skinny.c 226383 
>   /trunk/channels/chan_unistim.c 226383 
>   /trunk/channels/chan_vpb.cc 226383 
>   /trunk/channels/h323/chan_h323.h 226383 
>   /trunk/channels/iax2-parser.h 226383 
>   /trunk/channels/iax2-parser.c 226383 
>   /trunk/channels/iax2.h 226383 
>   /trunk/channels/sig_analog.c 226383 
>   /trunk/channels/sig_pri.c 226383 
>   /trunk/codecs/codec_dahdi.c 226383 
>   /trunk/codecs/ex_adpcm.h 226383 
>   /trunk/codecs/ex_alaw.h 226383 
>   /trunk/codecs/ex_g722.h 226383 
>   /trunk/codecs/ex_g726.h 226383 
>   /trunk/codecs/ex_gsm.h 226383 
>   /trunk/codecs/ex_ilbc.h 226383 
>   /trunk/codecs/ex_lpc10.h 226383 
>   /trunk/codecs/ex_speex.h 226383 
>   /trunk/codecs/ex_ulaw.h 226383 
>   /trunk/configure UNKNOWN 
>   /trunk/configure.ac 226383 
>   /trunk/doc/tex/channelvariables.tex 226383 
>   /trunk/formats/format_g723.c 226383 
>   /trunk/formats/format_g726.c 226383 
>   /trunk/formats/format_g729.c 226383 
>   /trunk/formats/format_gsm.c 226383 
>   /trunk/formats/format_h263.c 226383 
>   /trunk/formats/format_h264.c 226383 
>   /trunk/formats/format_ilbc.c 226383 
>   /trunk/formats/format_jpeg.c 226383 
>   /trunk/formats/format_ogg_vorbis.c 226383 
>   /trunk/formats/format_pcm.c 226383 
>   /trunk/formats/format_siren14.c 226383 
>   /trunk/formats/format_siren7.c 226383 
>   /trunk/formats/format_sln.c 226383 
>   /trunk/formats/format_sln16.c 226383 
>   /trunk/formats/format_vox.c 226383 
>   /trunk/formats/format_wav.c 226383 
>   /trunk/formats/format_wav_gsm.c 226383 
>   /trunk/funcs/func_volume.c 226383 
>   /trunk/include/asterisk/abstract_jb.h 226383 
>   /trunk/include/asterisk/audiohook.h 226383 
>   /trunk/include/asterisk/autoconfig.h.in 226383 
>   /trunk/include/asterisk/bridging.h 226383 
>   /trunk/include/asterisk/bridging_technology.h 226383 
>   /trunk/include/asterisk/channel.h 226383 
>   /trunk/include/asterisk/compat.h 226383 
>   /trunk/include/asterisk/frame.h 226383 
>   /trunk/include/asterisk/frame_defs.h PRE-CREATION 
>   /trunk/include/asterisk/pbx.h 226383 
>   /trunk/include/asterisk/rtp_engine.h 226383 
>   /trunk/include/asterisk/slin.h 226383 
>   /trunk/include/asterisk/slinfactory.h 226383 
>   /trunk/include/asterisk/translate.h 226383 
>   /trunk/include/asterisk/unaligned.h 226383 
>   /trunk/main/abstract_jb.c 226383 
>   /trunk/main/app.c 226383 
>   /trunk/main/audiohook.c 226383 
>   /trunk/main/autoservice.c 226383 
>   /trunk/main/bridging.c 226383 
>   /trunk/main/channel.c 226383 
>   /trunk/main/dial.c 226383 
>   /trunk/main/dsp.c 226383 
>   /trunk/main/features.c 226383 
>   /trunk/main/file.c 226383 
>   /trunk/main/frame.c 226383 
>   /trunk/main/indications.c 226383 
>   /trunk/main/manager.c 226383 
>   /trunk/main/pbx.c 226383 
>   /trunk/main/rtp_engine.c 226383 
>   /trunk/main/slinfactory.c 226383 
>   /trunk/main/strcompat.c 226383 
>   /trunk/main/translate.c 226383 
>   /trunk/main/udptl.c 226383 
>   /trunk/pbx/pbx_spool.c 226383 
>   /trunk/res/res_adsi.c 226383 
>   /trunk/res/res_agi.c 226383 
>   /trunk/res/res_musiconhold.c 226383 
>   /trunk/res/res_rtp_asterisk.c 226383 
>   /trunk/res/res_rtp_multicast.c 226383 
> 
> Diff: https://reviewboard.asterisk.org/r/416/diff
> 
> 
> Testing
> -------
> 
> Compile testing only.  Looking for architectural commentary and feedback while I work on testing.
> 
> 
> Thanks,
> 
> Tilghman
> 
>

More information about the asterisk-dev mailing list