[asterisk-dev] [Code Review] SIP Contact ACL's return bad error code

Olle E Johansson oej at edvina.net
Mon Oct 26 15:37:33 CDT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/415/
-----------------------------------------------------------

Review request for Asterisk Developers and Tilghman Lesher.


Summary
-------

When a REGISTER is denied because of the Contact ACL's, we return an error code that implies a bad format in the SIP request, which is wrong. This patch changes it to a policy error.

THis error code is only sent after successful authentication, so it's not exposing anything new.

This patch is for Asterisk 1.4. It needs to be merged in all branches from that up to trunk.


Diffs
-----

  /branches/1.4/channels/chan_sip.c 225916 

Diff: https://reviewboard.asterisk.org/r/415/diff


Testing
-------

Locally and at customer site.


Thanks,

Olle E




More information about the asterisk-dev mailing list