[asterisk-dev] [Code Review] better SDP parsing algorithm for 1.4

[Matthew Nicholson]

On 2009-10-19 12:03:27, frawd wrote:
> > Other than that, this looks good.  I want to hold off committing this until we also have patches for the 1.6 branches and trunk.  If you can, please look into porting the code.  If not, let me know.
> 
> frawd wrote:
>     One question while looking at the trunk code:
>     If I do a patch for trunk, is there possibility to automatically "merge" or something to the three 1.6 branches or will we need to create a specific patch for each 1.6 branch as well (that might be painful)?
>     
>     Other that that, I'm willing to work on that trunk-patch if you resolve bug 14446 somehow. Please tell me if you're willing to look into it. :-)
> 
> Matthew Nicholson wrote:
>     There is a possibility that changes for trunk will merge cleanly to one or more 1.6 branches (or the other way around), but I would not count on this.  Some of the patch should merge so you shouldn't have to start from scratch.  I took a look at bug 14446, it looks simple enough.
> 
> frawd wrote:
>     I appreciate you looking into it!
>     
>     From my side, surprise: I just finished an initial patch for trunk that compiles (at least). Where can I post it? New review request?

Yes, post it in a new review request.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/385/#review1188
-----------------------------------------------------------


On 2009-10-20 06:56:31, frawd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/385/
> -----------------------------------------------------------
> 
> (Updated 2009-10-20 06:56:31)
> 
> 
> Review request for Asterisk Developers, Olle E Johansson and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> This patch cleans up asterisk's SDP parsing algorithm, resolving a few bugs including #14994. It does the parsing line by line, making a distinction between session-level and media-specific parameters. It also optimizes the parsing adding functions for audio/video/image specific scanning.
> I added debug information for a better understanding on how the parsing is actually done (shows each SDP line parsed with OK or UNSUPPORTED).
> 
> If ported to 1.6 (sorry but I have no idea how the SIP code changed between 1.4 and 1.6 so I don't know how to do it), it will allow to easily add SDP functionality.
> 
> 
> This addresses bug 0014994.
>     https://issues.asterisk.org/view.php?id=0014994
> 
> 
> Diffs
> -----
> 
>   branches/1.4/channels/chan_sip.c 224737 
> 
> Diff: https://reviewboard.asterisk.org/r/385/diff
> 
> 
> Testing
> -------
> 
> Production tested for multiple audio and video devices in a version of the patch for 1.4.26.2 (see bug #14994).
> 
> Not tested with T.38, but it should work well.
> 
> 
> Thanks,
> 
> frawd
> 
>