[asterisk-dev] [Code Review] SIP: peer matching bycallbackextension

[Nick Lewis]

This good self-contained patch does not deserve to be kicked into the
long grass

-----Original Message-----
From: asterisk-dev-bounces at lists.digium.com
[mailto:asterisk-dev-bounces at lists.digium.com] On Behalf Of Olle E.
Johansson
Sent: 21 October 2009 15:28
To: Asterisk Developers Mailing List
Cc: Russell Bryant
Subject: Re: [asterisk-dev] [Code Review] SIP: peer matching
bycallbackextension


21 okt 2009 kl. 16.26 skrev Russell Bryant:

>
>
>> On 2009-10-09 06:18:23, Nick_Lewis wrote:
>>> I cannot think for the life of me why this config option would  
>>> ever be left off. There will no doubt be loads of people reporting  
>>> callback extension matching problems who will have to be told to  
>>> enable matching in the config. Eventually the asterisk team will  
>>> get sick of having to inform this never ending stream of people of  
>>> the config option and will flip or remove it. However if having  
>>> matching as a disabled option enables a consensus to be reached  
>>> then I am delighted
>
> Yeah, it's really just about providing another knob of control while  
> not changing the default behavior that has existed for quote a  
> while.  I'm good with this approach.
>

I strongly insist, as before, that we write a doc about all the  
changes and review them together instead of patching something that's  
already broken. We now have at least two changes on the table and more  
to come.

The whole callback extension code is a broken concept that should not  
have been there in the way it is from start. It's a bad patch without  
any architecture thinking behind it. I think we'd better fix that  
instead of adding new code to fix the broken code.



/O

_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

______________________________________________________________________
This e-mail has been scanned for all viruses by Star. The
service is powered by MessageLabs. For more information on a proactive
anti-virus service working around the clock, around the globe, visit:
http://www.star.net.uk
______________________________________________________________________

_____________________________________________________________________
This message has been checked for all known viruses by Star Internet delivered through the MessageLabs Virus Control Centre.
_____________________________________________________________________
Disclaimer of Liability
ATL Telecom Ltd shall not be held liable for any improper or incorrect use of the  information described and/or contained herein and assumes no responsibility for anyones use  of the information. In no event shall ATL Telecom Ltd be liable for any direct, indirect,  incidental, special, exemplary, or consequential damages (including, but not limited to,  procurement or substitute goods or services; loss of use, data, or profits; or business  interruption) however caused and on any theory of liability, whether in contract, strict  liability, or tort (including negligence or otherwise) arising in any way out of the use of  this system, even if advised of the possibility of such damage.

Registered Office: ATL Telecom Ltd, Fountain Lane, St. Mellons Cardiff, CF3 0FB
Registered in Wales Number 4335781

All goods and services supplied by ATL Telecom Ltd are supplied subject to ATL Telecom Ltd standard terms and conditions, available upon request.