[asterisk-dev] [Code Review] Add ISDN Calling and Called Subaddress support functions to LIBPRI

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/406/#review1189
-----------------------------------------------------------

Ship it!


Other than the type change below with some pssible cast changes and removing your ALEC debug messages, it looks like this is ready.


/team/rmudgett/subaddr/pri_internal.h
<https://reviewboard.asterisk.org/r/406/#comment2766>

    Missed this change.
    
    I'm thinking we need to change this to unsigned char to avoid possible sign extension problems when dealing with BCD data.  This is going to mean more casting, but it will also serve as a reminder that this data is not necessarily an ASCIIz string.
    
    There is one case I have seen where an existing cast could then be removed.  q931.c:receive_subaddr_helper()


- rmudgett


On 2009-10-18 03:53:17, Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/406/
> -----------------------------------------------------------
> 
> (Updated 2009-10-18 03:53:17)
> 
> 
> Review request for Asterisk Developers, rmudgett and mattf.
> 
> 
> Summary
> -------
> 
> Further Libpri support for subaddress, previously LIBPRI only supported receiving Calling Subaddress.
> 
> The first intentions of this are to add Transmit and Receive capabilites for Calling Subaddress and Called Subaddress.
> 
> Calling, Called and Redirecting Subaddress, now correctly supports User Specific type and the default NSAP.
> 
> Redirection Subaddress, Connectedline Subaddress have been identified, but will come later.
> 
> 
> This addresses bug 15604.
>     http://issues.asterisk.org/view.php?id=15604
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/subaddr/libpri.h 1218 
>   /team/rmudgett/subaddr/pri.c 1218 
>   /team/rmudgett/subaddr/pri_internal.h 1218 
>   /team/rmudgett/subaddr/pri_q931.h 1218 
>   /team/rmudgett/subaddr/q931.c 1218 
> 
> Diff: https://reviewboard.asterisk.org/r/406/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alec
> 
>