[asterisk-dev] [Code Review] better SDP parsing algorithm for 1.4

[Matthew Nicholson]

> On 2009-10-19 09:34:46, Matthew Nicholson wrote:
> > Please remove any whitespace changes not related to your patch and upload again.  Just make sure the changes in your patch have the proper formatting and leave existing formatting problems as they are.
> 
> frawd wrote:
>     Come on, no harm done!
>     
>     Ok to revert that, probably my biggest work so far, need to check 1 by 1 to see if part of the original patch (there might be an easier way but I'm not a patcher in my real life). I will then probably jump by the window right next to me to check how the ground below tastes.
>     
>     Grrrrrr... Learning to work for Digium is very hard.

Heh, sorry.  Not including unnecessary whitespace changes makes merging changes easier.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/385/#review1183
-----------------------------------------------------------


On 2009-10-19 10:40:51, frawd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/385/
> -----------------------------------------------------------
> 
> (Updated 2009-10-19 10:40:51)
> 
> 
> Review request for Asterisk Developers, Olle E Johansson and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> This patch cleans up asterisk's SDP parsing algorithm, resolving a few bugs including #14994. It does the parsing line by line, making a distinction between session-level and media-specific parameters. It also optimizes the parsing adding functions for audio/video/image specific scanning.
> I added debug information for a better understanding on how the parsing is actually done (shows each SDP line parsed with OK or UNSUPPORTED).
> 
> If ported to 1.6 (sorry but I have no idea how the SIP code changed between 1.4 and 1.6 so I don't know how to do it), it will allow to easily add SDP functionality.
> 
> 
> This addresses bug 0014994.
>     https://issues.asterisk.org/view.php?id=0014994
> 
> 
> Diffs
> -----
> 
>   branches/1.4/channels/chan_sip.c 224526 
> 
> Diff: https://reviewboard.asterisk.org/r/385/diff
> 
> 
> Testing
> -------
> 
> Production tested for multiple audio and video devices in a version of the patch for 1.4.26.2 (see bug #14994).
> 
> Not tested with T.38, but it should work well.
> 
> 
> Thanks,
> 
> frawd
> 
>