[asterisk-dev] [Code Review] Add ISDN Calling and Called Subaddress support functions to LIBPRI

[rmudgett at digium.com]

> On 2009-10-15 15:10:25, rmudgett wrote:
> > /team/rmudgett/subaddr/q931.c, line 3091
> > <https://reviewboard.asterisk.org/r/406/diff/2/?file=6747#file6747line3091>
> >
> >     With the generic subaddres helper functions, these connected subaddress functions will be trivial.  Also doing these functions will allow connected line with subaddress for the initial connect to work.  (Call transfers would require a lot more work.)
> >     
> >     Also, add Q931_IE_CONNECTED_SUBADDR to connect_ies[].
> 
>  wrote:
>     Transmit_connected_subaddres is now being called at the CONNECT.
>     
>     But I don't seem to be able to get 'connected line' to work, not only with subaddress but also with number.
>     The structures for number and subaddress appear empty, see debug code below "ALEC transmit_connected_number = 0!.
>     
>     debug code reveals when receiving a call:
>     Verbosity was 0 and is now 3
>         -- Accepting call from '48609' to '6882' on channel 0/1, span 1
>         -- Executing [6882 at incoming:1] NoOp("DAHDI/ISDN-1-1", "callingsubaddress = '1234' calledsubaddress = '55565'") in new stack
>         -- Executing [6882 at incoming:2] NoOp("DAHDI/ISDN-1-1", "CALLERID DNID='6882' DNID_SUBADDR='55565' ") in new stack
>         -- Executing [6882 at incoming:3] NoOp("DAHDI/ISDN-1-1", "CALLERID SUBADDR='1234'") in new stack
>         -- Executing [6882 at incoming:4] NoOp("DAHDI/ISDN-1-1", "CALLERID SUBADDR='1234'") in new stack
>         -- Executing [6882 at incoming:5] Set("DAHDI/ISDN-1-1", "CALLERID(number)=1234567") in new stack
>         -- Executing [6882 at incoming:6] Set("DAHDI/ISDN-1-1", "CALLERID(subaddr)=12345") in new stack
>         -- Executing [6882 at incoming:7] Set("DAHDI/ISDN-1-1", "CALLERID(subaddr-valid)=1") in new stack
>         -- Executing [6882 at incoming:8] Dial("DAHDI/ISDN-1-1", "DAHDI/34,5") in new stack
>         -- Called 34
>         -- DAHDI/34-1 is ringing
>         -- DAHDI/34-1 is ringing
>         -- DAHDI/34-1 is ringing
>         -- DAHDI/34-1 answered DAHDI/ISDN-1-1
>     ALEC transmit_connected_number valid = '0' !
>     ALEC transmit_connected_subaddr start:
>     ALEC transmit_subaddr_helper valid = '0'!
>         -- Native bridging DAHDI/ISDN-1-1 and DAHDI/34-1
>

You need to use the CONNECTEDLINE dialplan function to explicitly set the connected line data because DAHDI/34 is not ISDN (or SIP).  Also the Dial() should have the 'I' option set to prevent the CONNECTEDLINE data from being overwritten.  The 'I' option may not be strictly necessary in this case because DAHDI/34 looks to be an analog line.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/406/#review1172
-----------------------------------------------------------


On 2009-10-18 03:53:17, alecdavis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/406/
> -----------------------------------------------------------
> 
> (Updated 2009-10-18 03:53:17)
> 
> 
> Review request for Asterisk Developers, rmudgett and mattf.
> 
> 
> Summary
> -------
> 
> Further Libpri support for subaddress, previously LIBPRI only supported receiving Calling Subaddress.
> 
> The first intentions of this are to add Transmit and Receive capabilites for Calling Subaddress and Called Subaddress.
> 
> Calling, Called and Redirecting Subaddress, now correctly supports User Specific type and the default NSAP.
> 
> Redirection Subaddress, Connectedline Subaddress have been identified, but will come later.
> 
> 
> This addresses bug 15604.
>     http://issues.asterisk.org/view.php?id=15604
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/subaddr/libpri.h 1218 
>   /team/rmudgett/subaddr/pri.c 1218 
>   /team/rmudgett/subaddr/pri_internal.h 1218 
>   /team/rmudgett/subaddr/pri_q931.h 1218 
>   /team/rmudgett/subaddr/q931.c 1218 
> 
> Diff: https://reviewboard.asterisk.org/r/406/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> alecdavis
> 
>