[asterisk-dev] [Code Review] Hangup callee when caller hangs up during announcements in app_dial

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/407/#review1178
-----------------------------------------------------------



/branches/1.4/apps/app_dial.c
<https://reviewboard.asterisk.org/r/407/#comment2758>

    Errors opening the stream are not handled properly (this is also a bug in the current implementation).  This will be fixed before this patch is committed.


- Matthew


On 2009-10-16 16:24:35, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/407/
> -----------------------------------------------------------
> 
> (Updated 2009-10-16 16:24:35)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds code to app_dial to monitor the calling channel while playing an announcement to the callee so that hangups from the caller can be detected and properly handled.  Currently, if the caller hangs up while an announcement is playing to the announcement will continue to play to the callee.
> 
> I would especially like input on the best way to fix this problem.  The fix I have implemented works, but it duplicates code from waitstream_core().  I would like opinions regarding whether or not the functionality to monitor multiple channels in addition to servicing the streaming channel should be added to waitstream_core().  I started to implement the fix in waitstream_core() but that proved to be more complicated than implementing it in app_dial.
> 
> Note: Announcements are configured using the A() flag for app_dial.
> 
> 
> This addresses bug 16005.
>     https://issues.asterisk.org/view.php?id=16005
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/apps/app_dial.c 224259 
> 
> Diff: https://reviewboard.asterisk.org/r/407/diff
> 
> 
> Testing
> -------
> 
> Tested the patch by configuring an announcement, making a call, answering with the callee and hanging up the caller.
> 
> 
> Thanks,
> 
> Matthew
> 
>