[asterisk-dev] [Code Review] Add Calling and Called subaddress support for Asterisk apps and funcs

[rmudgett at digium.com]

> On 2009-10-16 13:33:30, rmudgett wrote:
> > /team/rmudgett/subaddr/channels/sig_pri.c, lines 2914-2915
> > <https://reviewboard.asterisk.org/r/405/diff/7/?file=6769#file6769line2914>
> >
> >     To get the calling subaddres into libpri we need to use the pri_sr_set_caller_party() here.
> >     
> >     #if defined(HAVE_PRI_SUBADDR)
> >     fill in a struct pri_party_id here.
> >     pri_sr_set_caller_party()
> >     #else
> >     <original code>
> >     #endif /* defined(HAVE_PRI_SUBADDR) */
> >     
> >     sig_pri_party_id_from_ast() might be able to do most of the work.

The need for this change could be sufficient justification to bring back pri_sr_set_calling_subaddress() as pri_sr_set_caller_subaddress().  The API call is still an overlap, but it will avoid the need to clean-up the mess here.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/405/#review1176
-----------------------------------------------------------


On 2009-10-16 06:55:54, alecdavis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/405/
> -----------------------------------------------------------
> 
> (Updated 2009-10-16 06:55:54)
> 
> 
> Review request for Asterisk Developers, rmudgett and mattf.
> 
> 
> Summary
> -------
> 
> Add dialstring support for called subaddress, used like Dial(dahdi/g0/5551234:8512) where 5551234 is the main line number of the remote site and 8512 is the extension with that site.
> If 'User Specific' BCD encoding is required, the subaddress is prefixed with a 'U'. IE Dial(dahdi/g0/5551234:U8512)
> 
> Extend function CALLERID() for type 'subaddr' to allow reading and updating the calling subaddress.
> Extend function CALLERID() for type 'dnid-subaddr' to allow reading and updating the called subaddress.
> Extend function CONNECTEDLINE as for CALLERID
> 
> 
> This addresses bug 15604.
>     https://issues.asterisk.org/view.php?id=15604
> 
> 
> Diffs
> -----
> 
>   /team/rmudgett/subaddr/channels/sig_pri.c 224259 
>   /team/rmudgett/subaddr/funcs/func_callerid.c 224259 
>   /team/rmudgett/subaddr/funcs/func_connectedline.c 224259 
>   /team/rmudgett/subaddr/include/asterisk/channel.h 224259 
>   /team/rmudgett/subaddr/main/channel.c 224259 
> 
> Diff: https://reviewboard.asterisk.org/r/405/diff
> 
> 
> Testing
> -------
> 
> Preliminary concept testing between sites over Telecom NZ PSTN, using channel variables $CALLINGSUBADDR and $CALLEDSUBADDR with patches for branches at https://issues.asterisk.org/view.php?id=15604 
> Development and testing using Jtec 5015 switches, establish calls in either direction, NSAP and User Specific.
> 
> 
> Thanks,
> 
> alecdavis
> 
>