[asterisk-dev] [Code Review] better SDP parsing algorithm for 1.4

[Matthew Nicholson]

> On 2009-10-13 16:01:36, Matthew Nicholson wrote:
> > branches/1.4/channels/chan_sip.c, lines 5455-5459
> > <https://reviewboard.asterisk.org/r/385/diff/2/?file=6549#file6549line5455>
> >
> >     This needs to be at the top of the block.
> 
>  wrote:
>     I am just referring to the definitions there.  Not the 'nextm =' line.
> 
>  wrote:
>     I don't know how to upload files to this review board, so I uploaded an SDP packet example to bug #14994 with the following URL:
>     https://issues.asterisk.org/file_download.php?file_id=24165&type=bug
>     
>     I will try the dev mode, but no idea what it does and what results I should look for (should I just report if it compiles ok?).
>     
>     Sorry in advance, I'm probably too slow this morning but please explain the "top of the block" issue. Is this a formatting issue? Are you talking about the "while" block (these lines are already on top of that block)? Should those variables be declared at the beginning of the function?
>     
>     Thanks again for the reviewing efforts, you are the best!

These variables should be placed at the top of that while() block.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/385/#review1164
-----------------------------------------------------------


On 2009-10-02 07:44:36, frawd wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/385/
> -----------------------------------------------------------
> 
> (Updated 2009-10-02 07:44:36)
> 
> 
> Review request for Asterisk Developers, Olle E Johansson and Matthew Nicholson.
> 
> 
> Summary
> -------
> 
> This patch cleans up asterisk's SDP parsing algorithm, resolving a few bugs including #14994. It does the parsing line by line, making a distinction between session-level and media-specific parameters. It also optimizes the parsing adding functions for audio/video/image specific scanning.
> I added debug information for a better understanding on how the parsing is actually done (shows each SDP line parsed with OK or UNSUPPORTED).
> 
> If ported to 1.6 (sorry but I have no idea how the SIP code changed between 1.4 and 1.6 so I don't know how to do it), it will allow to easily add SDP functionality.
> 
> 
> This addresses bug 0014994.
>     https://issues.asterisk.org/view.php?id=0014994
> 
> 
> Diffs
> -----
> 
>   branches/1.4/channels/chan_sip.c 221961 
> 
> Diff: https://reviewboard.asterisk.org/r/385/diff
> 
> 
> Testing
> -------
> 
> Production tested for multiple audio and video devices in a version of the patch for 1.4.26.2 (see bug #14994).
> 
> Not tested with T.38, but it should work well.
> 
> 
> Thanks,
> 
> frawd
> 
>