[asterisk-dev] [Code Review] CLI command 'manager logout <username> [from <ipaddress>]'

[Matthew Nicholson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/77/#review1160
-----------------------------------------------------------


This code does not have a way to choose which manager session to log off if multiple sessions are open from the same ip all using the same username.  This is not a huge problem, but I think it should be discussed and certainly documented if nothing more.

- Matthew


On 2009-02-20 19:31:37, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/77/
> -----------------------------------------------------------
> 
> (Updated 2009-02-20 19:31:37)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> CLI command 'manager logout <username> [from <ipaddress>]' as discussed on the mailing list (-dev).
> Please review twice the way I am logging out the user (how I am using the locks).
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 177785 
>   /trunk/main/manager.c 177785 
> 
> Diff: https://reviewboard.asterisk.org/r/77/diff
> 
> 
> Testing
> -------
> 
> Developer testing.
> 
> 
> Thanks,
> 
> Eliel
> 
>