[asterisk-dev] SIP URI checking in chan_sip.c

Kirill 'Big K' Katsnelson kkm at adaptiveai.com
Mon Nov 30 18:37:30 CST 2009


is nonexistent. Asterisk happily accepts URLs with invalid characters in 
them, even in pedantic mode (that one takes care of %xx hex 
substitutions only), and eventually leaks handles and crashes because of 
that. See my previous message <4B138244.8070000 at adaptiveai.com> "Failure 
on multiple malformed SIP URI".

Questions:

1. Why the pedantic mode exists at all, and is even off by default 
(non-RFC compliant SIP handling)?

2. Is that a problem that needs to be fixed? Am I missing anything? Yes 
crash is a problem, but how exactly that should be fixed:
  - non-compiant URLs rejected, or
  - non-compliant URLS accepted and digested without crashing?

I am for the former solution, as these are rejected by UAC anyway.

I am just trying to understand from what end I should approach the problem.

Thanks,

  -kkm



More information about the asterisk-dev mailing list