[asterisk-dev] [Code Review] Prevent duplicate entries in format strings used in app_voicemail

[Matthew Nicholson]

> On 2009-11-20 18:57:50, Russell Bryant wrote:
> > /branches/1.4/apps/app_voicemail.c, line 8548
> > <https://reviewboard.asterisk.org/r/429/diff/1/?file=7503#file7503line8548>
> >
> >     I have seen some bugs before caused by using ast_strdupa() directly in an argument list.  Since this results in an alloca, it results in some bizarre bad behavior.
> >     
> >     Just do it before calling the function, store the result, and pass that.

Fixed.


> On 2009-11-20 18:57:50, Russell Bryant wrote:
> > /branches/1.4/main/file.c, line 1411
> > <https://reviewboard.asterisk.org/r/429/diff/1/?file=7506#file7506line1411>
> >
> >     Since this isn't performance critical code anything, we might as well just use snprintf(), or we'll hear about it from people running static code analysis and such that blindly yell when you use functions like this.

Fixed.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/429/#review1270
-----------------------------------------------------------


On 2009-11-23 12:33:43, Matthew Nicholson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/429/
> -----------------------------------------------------------
> 
> (Updated 2009-11-23 12:33:43)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch adds the ast_format_str_reduce() function that will parse a '|' separated format string and remove any duplicate entries.  I am looking for feedback on the algorithm used here.  I believe it to be correct, but it is not very efficient and requires traversing the format list once for every format found in the format string.  This function is only called once (thus far), for each instance of the asterisk process, so efficiency is not the chief concern here, but any improvements are welcome.
> 
> This change is necessary because specifying the same format twice in app_voicemail will cause perpending a forwarded message to infinitely loop and fill up the hard disk as it prepends a message to itself.  Also, there is no reason that I can think of to specify the same format twice.
> 
> 
> This addresses bug 15625.
>     https://issues.asterisk.org/view.php?id=15625
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/apps/app_voicemail.c 230951 
>   /branches/1.4/include/asterisk/file.h 230951 
>   /branches/1.4/main/app.c 230951 
>   /branches/1.4/main/file.c 230951 
> 
> Diff: https://reviewboard.asterisk.org/r/429/diff
> 
> 
> Testing
> -------
> 
> Tested with the string "WAV|wav49|gsm".  WAV and wav49 are the same formats, the string is reduced to "WAV|gsm".
> 
> 
> Thanks,
> 
> Matthew
> 
>