[asterisk-dev] [Code Review] audiohook: signal to trigger on every status change

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/434/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This is a very simple patch.  ast_audiohook_trigger_wait waits for the audiohook->trigger to be signaled.  This is used to indicate when a frame has been written or the status is set to DONE, but it seems like it would be useful to signal on all status changes.  By doing this, StopMixMonitor wouldn't have to signal the audiohook trigger to guarantee the MixMonitor thread will exit promptly, the audiohook code would do the signaling for it when the status is changed to SHUTDOWN in ast_audiohook_detach_source.  I'm sure there are other places this makes sense as well.

This patch also fixes a few areas where the audiohook's status is set to DONE but the trigger is not signaled.


Diffs
-----

  /trunk/include/asterisk/audiohook.h 230508 
  /trunk/main/audiohook.c 230508 

Diff: https://reviewboard.asterisk.org/r/434/diff


Testing
-------

Tested with MixMonitor, everything worked as expected.


Thanks,

David