[asterisk-dev] [Code Review] Implement error events for non-existant files

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/430/#review1263
-----------------------------------------------------------

Ship it!



/trunk/apps/app_externalivr.c
<https://reviewboard.asterisk.org/r/430/#comment2921>

    This is just a matter of style, but the form ...
    
    if (!ast_fileexists())
    
    ... is a more common way to check for a zero result throughout the code base, so I'd prefer that when I have the choice.


- Russell


On 2009-11-19 09:49:24, thedavidfactor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/430/
> -----------------------------------------------------------
> 
> (Updated 2009-11-19 09:49:24)
> 
> 
> Review request for Asterisk Developers and Chris Tooley.
> 
> 
> Summary
> -------
> 
> A reimplementation of error events for non-existing files. This implements the change in code and updates the documentation to reflect the functionality. 
> 
> 
> This addresses bug 16123.
>     https://issues.asterisk.org/view.php?id=16123
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_externalivr.c 230438 
>   /trunk/doc/externalivr.txt 230437 
> 
> Diff: https://reviewboard.asterisk.org/r/430/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> thedavidfactor
> 
>