[asterisk-dev] [Code Review] StopMixMonitor not stopping mixmonitor thread

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/424/#review1259
-----------------------------------------------------------

Ship it!


Nice work, sir.


/branches/1.4/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/424/#comment2915>

    To doxygenify this ...
    
    /*!
     * \internal
     * \pre mixmonitor_ds must be ...
     */


- Russell


On 2009-11-11 12:19:24, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/424/
> -----------------------------------------------------------
> 
> (Updated 2009-11-11 12:19:24)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> StopMixMonitor will close the filestream, but the thread does not exit properly until channel destruction.  This patch fixes that.
> 
> To get the thread to exit when StopMixMonitor is used I had to change two things.
> 1. The audiohook must be triggered for the status change caused by the ast_audiohook_detach_source() call.  Without this the mixmonitor thread may be stuck waiting on the audiohook trigger until channel destruction even though the audiohook's status has changed.
> 2. The datastore must be removed from the channel and freed.  This allows the mixmonitor thread to exit cleanly without having to wait for channel destruction to remove the datastore.
> 
> 
> This addresses bug 16152.
>     https://issues.asterisk.org/view.php?id=16152
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/apps/app_mixmonitor.c 229350 
> 
> Diff: https://reviewboard.asterisk.org/r/424/diff
> 
> 
> Testing
> -------
> 
> Tested several combinations of MixMonitor and StopMixMonitor, verified thread exits properly. 
> 
> 
> Thanks,
> 
> David
> 
>