[asterisk-dev] [Code Review] Basic app_externalivr clean up

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/428/#review1257
-----------------------------------------------------------



/trunk/apps/app_externalivr.c
<https://reviewboard.asterisk.org/r/428/#comment2911>

    It looks like this never gets freed.



/trunk/apps/app_externalivr.c
<https://reviewboard.asterisk.org/r/428/#comment2912>

    ast_verb() should be used here.



/trunk/apps/app_externalivr.c
<https://reviewboard.asterisk.org/r/428/#comment2913>

    Use ast_verb()


- Russell


On 2009-11-16 09:48:37, thedavidfactor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/428/
> -----------------------------------------------------------
> 
> (Updated 2009-11-16 09:48:37)
> 
> 
> Review request for Asterisk Developers and Chris Tooley.
> 
> 
> Summary
> -------
> 
> This is the first of several patches for ExternalIVR. My goal is to clean up the messages and argument parsing. All the debug messages and a lot of the log messages have been changed to verbose messages. All errors that result in EIVR ending prematurely or unexpectedly are now logged as errors. This is the first draft so comments/question are solicited.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_externalivr.c 229668 
> 
> Diff: https://reviewboard.asterisk.org/r/428/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> thedavidfactor
> 
>